[QEff. Finetune]: Added component registry and factory functionality. #641
+361
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quic-meetkuma
commented
Nov 26, 2025
quic-meetkuma
commented
- Added functionality to register dataset, model, optimizer, trainer objects in a registry and fetch the class of given object based on configuration provided.
- Also, added simple test cases to verify the functionality.
quic-meetkuma
requested review from
ochougul,
quic-akuruvil,
quic-swatia,
tchawada and
vbaddi
Signed-off-by: meetkuma <[email protected]>
quic-meetkuma
force-pushed
the
hf_trainer_registry
branch
from
531b407 to
c4fa7db
Compare
Signed-off-by: meetkuma <[email protected]>
quic-swatia
reviewed
Nov 28, 2025
|
|
||
|
|
||
| import logging | ||
| from typing import Tuple, Dict, Optional, Type, List, Callable |
Contributor
There was a problem hiding this comment.
Please remove unused imports so that lint check can pass.
Contributor
Author
There was a problem hiding this comment.
Updated in latest.
Signed-off-by: meetkuma <[email protected]>
Contributor
Author
|
Discarding this PR in favor of #645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.